-
Notifications
You must be signed in to change notification settings - Fork 115
Fix expand_wildcards default values #5599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
pquentin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expand_wildcards is special because there's no real default value, each API can set its own.
| * Type of data stream that wildcard patterns can match. | ||
| * Supports comma-separated values, such as `open,hidden`. | ||
| * @server_default open | ||
| * @server_default open,closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * If the request can target data streams, this argument determines whether wildcard expressions match hidden data streams. | ||
| * Supports comma-separated values, such as `open,hidden`. | ||
| * @server_default open | ||
| * @server_default open,closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * If the request can target data streams, this argument determines whether wildcard expressions match hidden data streams. | ||
| * Supports comma-separated values, such as `open,hidden`. | ||
| * @server_default open | ||
| * @server_default all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * If the request can target data streams, this argument determines whether wildcard expressions match hidden data streams. | ||
| * Supports comma-separated values, such as `open,hidden`. | ||
| * @server_default open | ||
| * @server_default all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as indices.exist_alias above
| * If the request can target data streams, this argument determines whether wildcard expressions match hidden data streams. | ||
| * Supports comma-separated values, such as `open,hidden`. | ||
| * @server_default open | ||
| * @server_default closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
everything checks out, thank you for the thorough work! |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5599-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 245d55fe36b997baad0b688e499d116185c8e21b
# Push it to GitHub
git push --set-upstream origin backport-5599-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19Then, create a pull request where the |
* Specify default_value for expand_wildcards * Fix one default value (cherry picked from commit 245d55f)
* Specify default_value for expand_wildcards * Fix one default value (cherry picked from commit 245d55f)
* Specify default_value for expand_wildcards * Fix one default value (cherry picked from commit 245d55f) # Conflicts: # specification/indices/delete_data_stream_options/IndicesDeleteDataStreamOptionsRequest.ts
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
No description provided.